Repository navigation
all: ignore local Oboe source archives - #319
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Oboe generator accepts a local internal/oboe/.tar.gz instead of downloading it. Ignore those local source archives so this supported development cache does not appear among files to commit. Vendored sources and the generator remain tracked normally.
Validation: native macOS arm64 internal race tests, internal vet, and the other vet analyzers passed. Full go vet reports the same pre-existing Darwin unsafe.Pointer warning as upstream main. Native macOS arm64 build passed. Actual git check-ignore failed to ignore the archive on the base and ignores it after the change; source and license files remain unignored.